Skip to content

refactor(core): extract portable cloud task engine#3608

Open
richardsolomou wants to merge 1 commit into
posthog-code/share-cloud-task-enginefrom
posthog-code/share-mobile-cloud-task-core
Open

refactor(core): extract portable cloud task engine#3608
richardsolomou wants to merge 1 commit into
posthog-code/share-cloud-task-enginefrom
posthog-code/share-mobile-cloud-task-core

Conversation

@richardsolomou

@richardsolomou richardsolomou commented Jul 21, 2026

Copy link
Copy Markdown
Member

Problem

The renamed desktop cloud-task service still owns host-specific dependencies and cannot be reused by another host.

Depends on #3624
Refs #2416

Changes

Phase 1 only: I made the renamed implementation host-neutral and added the thin desktop cloud-task.ts wrapper. Because the move landed separately, this diff contains the actual engine changes rather than a 2,000-line delete/add pair.

How did you test this?

  • Full monorepo typecheck at this checkpoint
  • Final stack: 711 shared, 153 API-client, 2,599 core, and 451 mobile tests

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Created with PostHog Code

@trunk-io

trunk-io Bot commented Jul 21, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@richardsolomou richardsolomou changed the title Share desktop cloud task core with mobile refactor(mobile): reuse shared cloud task architecture Jul 21, 2026
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit e3d7ad0.

@richardsolomou richardsolomou changed the title refactor(mobile): reuse shared cloud task architecture refactor(mobile): adopt shared cloud task sessions Jul 21, 2026
@richardsolomou
richardsolomou changed the base branch from main to posthog-code/share-cloud-task-foundations July 21, 2026 11:38
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-cloud-task-core branch from 71a9410 to bc3432b Compare July 21, 2026 11:39
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-foundations branch from 8c39d0e to f08bac5 Compare July 21, 2026 12:30
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-cloud-task-core branch from bc3432b to 469e7c2 Compare July 21, 2026 12:34
@richardsolomou
richardsolomou changed the base branch from posthog-code/share-cloud-task-foundations to posthog-code/share-cloud-task-engine July 21, 2026 12:35
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-engine branch from 2dafbcd to 1b48f46 Compare July 21, 2026 13:46
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-cloud-task-core branch from 469e7c2 to 70e84e9 Compare July 21, 2026 13:58
@richardsolomou richardsolomou changed the title refactor(mobile): adopt shared cloud task sessions refactor(mobile): finish shared cloud task adoption Jul 21, 2026
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-engine branch from 32895be to 54e687e Compare July 23, 2026 12:55
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-cloud-task-core branch from 70e84e9 to dde4532 Compare July 23, 2026 12:59
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-engine branch from 54e687e to 25563d8 Compare July 23, 2026 13:35
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-cloud-task-core branch from dde4532 to 8c45346 Compare July 23, 2026 13:36
@greptile-apps

greptile-apps Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "fix(mobile): select a visible fallback m..." | Re-trigger Greptile

@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-cloud-task-core branch from 996c103 to 23dec67 Compare July 23, 2026 17:28
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-engine branch from bdfa389 to 5e38056 Compare July 23, 2026 17:28
Comment thread apps/mobile/src/app/task/index.tsx Outdated
@veria-ai

veria-ai Bot commented Jul 23, 2026

Copy link
Copy Markdown

PR overview

All previously flagged issues have been addressed. No open security concerns remain on this pull request.

Security review

No open security issues remain on this pull request.

Fixed/addressed: 1 · PR risk: 0/10

@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-engine branch from 5e38056 to f703289 Compare July 24, 2026 16:41
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-cloud-task-core branch from 26dda58 to 2ae0612 Compare July 24, 2026 16:41
@richardsolomou richardsolomou changed the title refactor(mobile): finish shared cloud task adoption refactor(core): extract portable cloud task engine Jul 24, 2026
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-engine branch from f703289 to 5bbe73f Compare July 24, 2026 16:47
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-cloud-task-core branch from 2ae0612 to e1af136 Compare July 24, 2026 16:47
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-engine branch from 5bbe73f to ae97a33 Compare July 24, 2026 22:26
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-cloud-task-core branch 2 times, most recently from 3e528fe to 2ea8e81 Compare July 24, 2026 22:57
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-engine branch from ae97a33 to 059b248 Compare July 24, 2026 22:57
Generated-By: PostHog Code
Task-Id: c1bbe3cf-742b-4b24-bf96-d11a18b4cf22
@richardsolomou
richardsolomou force-pushed the posthog-code/share-mobile-cloud-task-core branch from 2ea8e81 to e3d7ad0 Compare July 24, 2026 23:07
@richardsolomou
richardsolomou force-pushed the posthog-code/share-cloud-task-engine branch from 059b248 to ee6ce05 Compare July 24, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant